rohangarg commented on a change in pull request #12314:
URL: https://github.com/apache/druid/pull/12314#discussion_r821342874
##########
File path:
processing/src/main/java/org/apache/druid/segment/filter/cnf/HiveCnfHelper.java
##########
@@ -178,6 +179,11 @@ private static void generateAllCombinations(
a.add(child);
// Result must receive an actual OrFilter.
result.add(idempotentOr(Filters.or(a)));
+ if (result.size() >= 10_000) {
Review comment:
this could be configurable - didn't keep it as of now to avoid more
configs.
but if it feels like disruptive (because it could lead to failure in some
existing queries which create > 10k filters and still run), I can add a config
for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
