abhishekagarwal87 commented on PR #12418: URL: https://github.com/apache/druid/pull/12418#issuecomment-1097605710
I am definitely concerned about increased planning time. The druidRel would have been validated already but we would still explain it repeatedly. This could be a problem for queries that have many levels of nesting. Again, the problem is not in the `explain` itself. It's just that `isValidDruidQuery` and `transformTo` are calling `explain` on query with different inputs. Those inputs are different because of `transformTo` function. I will still recommend the other approach so that we can just ignore bad in-flight transformations and move on to other rules. Also, the scan query need not require ordering on the time column when the underlying data source is a query data source. That is actually bound to give wrong ordering because underlying data itself is not sorted by time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
