somu-imply commented on code in PR #12418:
URL: https://github.com/apache/druid/pull/12418#discussion_r850573795
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -6719,6 +6719,12 @@ public void testMinMaxAvgDailyCountWithLimit() throws
Exception
)
)
.setInterval(querySegmentSpec(Filtration.eternity()))
+ .setLimitSpec(
Review Comment:
Yes the previous would have been `limitSpec=NoopLimitSpec` but now it
changed to `limitSpec=DefaultLimitSpec{columns='[]', offset=0, limit=1}` . But
considering the query has a LIMIT 1 at the end, I thought this was acceptable.
I updated the limit to a different value and it shows up in the DefaultLimitSpec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
