abhishekagarwal87 commented on PR #12418:
URL: https://github.com/apache/druid/pull/12418#issuecomment-1094530397
Hi Somu, In this case, the transformation can be deemed invalid and the
assumption is that calcite will find another plan as it continues exploring. I
am assuming that ignoring an exception during transformation is fine but it can
be confirmed by asking on the calcite dev mailing list (they are very
responsive).
The reason for suggesting this approach is that it can cover more failures
scenarios such as the one you put out in the description. Otherwise, we might
end up with lot of scenario-specific handling in different parts of the code.
Also, as this change is being tested, it might be worth adding test cases
such as below
- join between two scan queries with a join on alias of time column
```(select __time as dim1, dim2 from table1 group by 1, 2 order by 1) as
T1 INNER JOIN (select __time as a1, a2 from table2 group by 1, 2 order by 1) as
T2 ON T1.dim1 = T2.a1```
- Verify that the output field names returned are correct in the header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
