FrankChen021 commented on code in PR #12570:
URL: https://github.com/apache/druid/pull/12570#discussion_r882669373


##########
examples/bin/run-druid:
##########
@@ -42,7 +42,7 @@ if [ -z "$JAVA_BIN" ]; then
   exit 1
 fi
 
-LOG_DIR="${DRUID_LOG_DIR:=${WHEREAMI}/log}"
+LOG_DIR="${DRUID_LOG_DIR:=${WHEREAMI}/../log}"

Review Comment:
   
https://github.com/apache/druid/blame/master/docs/operations/single-server.md#L51
   
   The doc launches the server at druid directory, so this change will put log 
at this directory: 
   druid_directory/../log
   
   I think it's more intuitive to create the log directory at the directory 
where user executes the startup script.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to