gianm commented on code in PR #12570:
URL: https://github.com/apache/druid/pull/12570#discussion_r884223972


##########
examples/bin/run-druid:
##########
@@ -42,7 +42,7 @@ if [ -z "$JAVA_BIN" ]; then
   exit 1
 fi
 
-LOG_DIR="${DRUID_LOG_DIR:=${WHEREAMI}/log}"
+LOG_DIR="${DRUID_LOG_DIR:=${WHEREAMI}/../log}"

Review Comment:
   > I think it's more intuitive to create the log directory at the directory 
where user executes the startup script.
   
   That's what I thought I was doing! 🙂
   
   When I ran the `bin/start-micro-quickstart` command like we have in the 
tutorials, with the script currently in master, logs were created in `bin/log/` 
in the root of the distribution. This seemed strange so I wanted to change it 
to `log/`. So that's why I added the `../`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to