paul-rogers commented on code in PR #12570:
URL: https://github.com/apache/druid/pull/12570#discussion_r887358195
##########
examples/bin/run-druid:
##########
@@ -42,7 +42,7 @@ if [ -z "$JAVA_BIN" ]; then
exit 1
fi
-LOG_DIR="${DRUID_LOG_DIR:=${WHEREAMI}/log}"
+LOG_DIR="${DRUID_LOG_DIR:=${WHEREAMI}/../log}"
Review Comment:
The location depends on the directory you are in when you launch Druid.
Sounds like @gian launches Druid from within the `$DRUID_HOME/bin` directory.
But, I always do it from `$DRUID_HOME`: `./bin/start-micro-quickstart` which is
how Apache tools usually work.
A better place to put Druid logs is `$DRUID_HOME/var/druid`, which is where
`derby.log`, `indexing-logs` and others end up. If that directory is a bit too
general, then perhaps `$DRUID_HOME/var/log/druid` (moving the other logs to
match).
It appears that `$WHEREAMI` in `start-micro-quickstart` is the directory
that contains the script, so `$DRUID_HOME/bin`. The same is true in
`bin/run-druid`. It is odd, however, that `start-micro-quickstart` does not
call `run-druid`, so any changes you make in `run-druid` won't affect
`start-micro-quickstart`.
I would argue this line in `run-druid` is wrong:
```bash
LOG_DIR="${DRUID_LOG_DIR:=${WHEREAMI}/log}"
```
That will put the log in `$DRUID_HOME/bin/log` which seems quite odd. Maybe
change it to:
```bash
LOG_DIR="${DRUID_LOG_DIR:=${WHEREAMI}/../var/log/druid}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
