paul-rogers opened a new pull request, #12673: URL: https://github.com/apache/druid/pull/12673
The [new IT PR](https://github.com/apache/druid/pull/12368/files#) has struggled to get a clean build due to the complexity and flakiness of the Druid build system. It is ironic that the attempt to fix the ITs has been stymied by the fragility of the existing ITs. Out of desperation, the big PR is being broken up into smaller chunks. This one provides changes made to the existing ITs to support the new ITs. The first set of changes make the "custom node role" code usable by the new ITs. No functional change, just some clean-up. There are also some documentation updates. The second change is more substantial. The new ITs use the "failsafe" Maven plugin, which is the sister plugin to the "failsafe" plugin Druid uses for unit tests (UTs). The venerable `-DskipTests` flag will thus skip both ITs and UTs. But, when running the new ITs, we want to skip the UTs, but run the ITs. A [common solution](https://maven.apache.org/surefire/maven-failsafe-plugin/examples/skipping-tests.html) is to [use separate flags for ITs and UTs](https://stackoverflow.com/questions/6612344/prevent-unit-tests-but-allow-integration-tests-in-maven). * `-DskipITs` skips the integration tests but runs unit tests. * `-DskipUTs` skips unit tests but runs the "new" integration tests. The existing Druid profile, `-P skip-tests` is expanded to skip both ITs and UTs. In this PR, `-DskipTests` and `-DskipUTs` have the same effect. However, once the new ITs are in place, the meanings will differ, as explained above. The key purpose of this PR is to test the new setup in Travis separately from the other changes in PR #12368. <hr> This PR has: - [X] been self-reviewed. - [X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [X] has been tested in the Travis Druid build (the purpose of this PR.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
