cryptoe commented on code in PR #12673:
URL: https://github.com/apache/druid/pull/12673#discussion_r901228356
##########
integration-tests/src/main/java/org/apache/druid/testing/IntegrationTestingConfig.java:
##########
@@ -23,6 +23,19 @@
import java.util.Map;
/**
+ * Configuration for tests. Opinionated about the shape of the cluster:
Review Comment:
Nit: Is this required as part of the uber PR
##########
integration-tests/src/main/java/org/apache/druid/cli/CustomNodeRoleCommandCreator.java:
##########
@@ -23,6 +23,7 @@
public class CustomNodeRoleCommandCreator implements CliCommandCreator
{
+ @SuppressWarnings({ "rawtypes", "unchecked" })
Review Comment:
Nit: Is this required as part of the uber PR ? Can the annotation be removed
as part of this PR ?
##########
pom.xml:
##########
@@ -1183,6 +1191,13 @@
<exclude>org/apache/druid/benchmark/**/*</exclude>
<!-- benchmarks -->
<exclude>org/apache/druid/**/*Benchmark*</exclude>
<!-- benchmarks -->
<exclude>org/apache/druid/testing/**/*</exclude> <!--
integration-tests -->
+ <!-- The ITs has test code sprinked through the module
tree. Remove the following
+ once the old version is retired. -->
Review Comment:
Can we create an issue for this if we haven't already? This will help us
keep track of the todo's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
