paul-rogers commented on code in PR #12636:
URL: https://github.com/apache/druid/pull/12636#discussion_r900701108
##########
sql/src/main/java/org/apache/druid/sql/calcite/view/DruidViewMacro.java:
##########
@@ -58,6 +58,7 @@ public TranslatableTable apply(final List<Object> arguments)
{
final RelDataType rowType;
try (final DruidPlanner planner = plannerFactory.createPlanner(viewSql,
new QueryContext())) {
+ planner.validate(false);
Review Comment:
What I saw in the code is that the Avatica path did validate, authorize,
prepare. But, the view path did validate, prepare but no authorize (it has no
auth result or request). The flow before and after the change is the same. For
Avatica, the path is validate, authorize, prepare. The query path is validate,
authorized, plan. The view path is validate, prepare (with no authorize). Does
this sound right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
