clintropolis commented on PR #12636: URL: https://github.com/apache/druid/pull/12636#issuecomment-1155678113
heh, I think I wrote that comment 😅 iirc the main reason I didn't make the change at the time is because I didn't want to validate that stateful jdbc connections actually worked if we made them be _actually_ stateful (instead of repeating the work per request). So this is probably the area where most testing should focus, especially on prepared statements with dynamic parameters. IIRC, for dynamic parameters, I think we do actually want to re-run through the planner once we have values for the actual parameter bindings because some stuff can be optimized during planning, but... it was a while ago when I wired them up so maybe its not an issue? Anyway, I'll try to have a closer look at this sometime soon :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
