paul-rogers commented on PR #12636: URL: https://github.com/apache/druid/pull/12636#issuecomment-1155746430
@gianm, thanks for the background. The new planner test framework will catch the kinds of issues you mention: it captures the details of the Calcite logical plan (as well as the native query, like the existing tests do.) The good news is that the original version of these changes were done in a branch that had the new planner tests, and they reported no changes in the Calcite artifacts. That said, it is worth spending time to trace exactly how we handle parameters to be sure we account for the proper flow. In general, there should be no reason to replan a query under normal conditions: other tools that use Calcite generally make do with a single pass. Where tools tend to plan a second time is if the planner paints itself into a corner, some global state is changed, and the planner is run a different way. (Impala used to do that.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
