AmatyaAvadhanula commented on code in PR #12743:
URL: https://github.com/apache/druid/pull/12743#discussion_r914459721
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java:
##########
@@ -850,12 +850,12 @@ private TaskStatus generateAndPublishSegments(
new FireDepartment(dataSchema, new RealtimeIOConfig(null, null), null);
FireDepartmentMetrics buildSegmentsFireDepartmentMetrics =
fireDepartmentForMetrics.getMetrics();
+ final TaskRealtimeMetricsMonitor metricsMonitor =
TaskRealtimeMetricsMonitorBuilder.build(
+ this,
+ fireDepartmentForMetrics,
+ buildSegmentsMeters
+ );
if (toolbox.getMonitorScheduler() != null) {
Review Comment:
Nit: Can `toolbox.getMonitorScheduler` be separated to avoid repetitive
usages of this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
