tejaswini-imply commented on code in PR #12743:
URL: https://github.com/apache/druid/pull/12743#discussion_r914626494
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java:
##########
@@ -850,12 +850,12 @@ private TaskStatus generateAndPublishSegments(
new FireDepartment(dataSchema, new RealtimeIOConfig(null, null), null);
FireDepartmentMetrics buildSegmentsFireDepartmentMetrics =
fireDepartmentForMetrics.getMetrics();
+ final TaskRealtimeMetricsMonitor metricsMonitor =
TaskRealtimeMetricsMonitorBuilder.build(
+ this,
+ fireDepartmentForMetrics,
+ buildSegmentsMeters
+ );
if (toolbox.getMonitorScheduler() != null) {
Review Comment:
Thanks for pointing this out, this code is written before adding
`addMonitor` and `removeMonitor` methods in `TaskToolBox` where null-handling
is being taken care of. So removing it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
