tejaswini-imply commented on code in PR #12743: URL: https://github.com/apache/druid/pull/12743#discussion_r914462839
########## indexing-service/src/main/java/org/apache/druid/indexing/common/stats/TaskRealtimeMetricsMonitor.java: ########## @@ -50,6 +50,8 @@ public class TaskRealtimeMetricsMonitor extends AbstractMonitor private FireDepartmentMetrics previousFireDepartmentMetrics; private RowIngestionMetersTotals previousRowIngestionMetersTotals; + private volatile boolean lastRoundMetricsToBePushed = true; Review Comment: I'm thinking if monitor method can simply `return doMonitor(emitter) && started;` removing the necessity for `lastRoundMetricsToBePushed` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
