imply-cheddar commented on code in PR #12767:
URL: https://github.com/apache/druid/pull/12767#discussion_r918387072
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskLifecycleTest.java:
##########
@@ -1359,7 +1360,7 @@ public void testUnifiedAppenderatorsManagerCleanup()
throws Exception
UnifiedIndexerAppenderatorsManager unifiedIndexerAppenderatorsManager =
new UnifiedIndexerAppenderatorsManager(
new ForwardingQueryProcessingPool(exec),
- NoopJoinableFactory.INSTANCE,
+ new JoinableFactoryWrapper(NoopJoinableFactory.INSTANCE),
Review Comment:
Pretty sure this is effectively the same as the `MapJoinableFactory` objects
with empty maps that other tests are using
##########
benchmarks/src/test/java/org/apache/druid/benchmark/query/CachingClusteredClientBenchmark.java:
##########
@@ -343,7 +344,7 @@ public <T, QueryType extends Query<T>> QueryToolChest<T,
QueryType> getToolChest
processingConfig,
forkJoinPool,
QueryStackTests.DEFAULT_NOOP_SCHEDULER,
- new MapJoinableFactory(ImmutableSet.of(), ImmutableMap.of()),
+ new JoinableFactoryWrapper(new MapJoinableFactory(ImmutableSet.of(),
ImmutableMap.of())),
Review Comment:
Nitty nit: You could introduce a `TestJoinableFactoryWrapper` that is
essentially this same noop thing, but more unified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
