rohangarg commented on code in PR #12767:
URL: https://github.com/apache/druid/pull/12767#discussion_r918561222
##########
benchmarks/src/test/java/org/apache/druid/benchmark/query/CachingClusteredClientBenchmark.java:
##########
@@ -343,7 +344,7 @@ public <T, QueryType extends Query<T>> QueryToolChest<T,
QueryType> getToolChest
processingConfig,
forkJoinPool,
QueryStackTests.DEFAULT_NOOP_SCHEDULER,
- new MapJoinableFactory(ImmutableSet.of(), ImmutableMap.of()),
+ new JoinableFactoryWrapper(new MapJoinableFactory(ImmutableSet.of(),
ImmutableMap.of())),
Review Comment:
fixed, now all tests use a unified `new
JoinableFactoryWrapper(NoopJoinableFactory.INSTANCE)` from
`JoinableFactoryWrapperTest.NOOP_JOINABLE_FACTORY_WRAPPER`
the moving average query tests don't use it right now since that'll require
adding test-jar dep from processing in moving average, which doesn't seem
necessary at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
