FrankChen021 commented on issue #12912: URL: https://github.com/apache/druid/issues/12912#issuecomment-1221918198
Hi @BartMiki Changing the signature of `toMap` does require to change all subclasses of `Event` interfaces. It's acceptable in this case. I don't think the `EventMap` needs to be immutable because it does not hold any reference to original Event object it self. The reason immutable map is used I think is because it provides a builder pattern so that we can build a map object in chain. which simplifies the coding. To make code change simpler, we can provide a builder pattern against `EventMap`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
