clintropolis commented on code in PR #12277: URL: https://github.com/apache/druid/pull/12277#discussion_r980392013
########## core/src/main/java/org/apache/druid/segment/data/VByte.java: ########## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment.data; + +import java.nio.ByteBuffer; + +public class VByte +{ + /** + * Read a variable byte (vbyte) encoded integer from a {@link ByteBuffer} at the current position. + * + * vbyte encoding stores values in the last 7 bits of a byte and reserves the high bit for the 'contination'. If 0, + * one or more aditional bytes must be read to complete the value, and a 1 indicates the terminal byte. Because of + * this, it can only store positive values, and larger integers can take up to 5 bytes. + * + * implementation based on: + * https://github.com/lemire/JavaFastPFOR/blob/master/src/main/java/me/lemire/integercompression/VariableByte.java + * + */ + public static int readInt(ByteBuffer buffer) Review Comment: I hadn't got to playing around with this yet to make this change. It would probably be fine for the iterator to read this way, but the get method at least would benefit from this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
