clintropolis commented on code in PR #12277:
URL: https://github.com/apache/druid/pull/12277#discussion_r980396911
##########
processing/src/main/java/org/apache/druid/segment/IndexSpec.java:
##########
@@ -116,37 +98,44 @@ public IndexSpec(
* @param dimensionCompression compression format for dimension columns,
null to use the default.
* Defaults to {@link
CompressionStrategy#DEFAULT_COMPRESSION_STRATEGY}
*
+ * @param stringDictionaryEncoding encoding strategy for string dictionaries
of dictionary encoded string columns
+ *
* @param metricCompression compression format for primitive type metric
columns, null to use the default.
* Defaults to {@link
CompressionStrategy#DEFAULT_COMPRESSION_STRATEGY}
*
* @param longEncoding encoding strategy for metric and dimension columns
with type long, null to use the default.
* Defaults to {@link
CompressionFactory#DEFAULT_LONG_ENCODING_STRATEGY}
+ *
+ * @param segmentLoader specify a {@link SegmentizerFactory} which will be
written to 'factory.json' and used to load
+ * the written segment
*/
@JsonCreator
public IndexSpec(
@JsonProperty("bitmap") @Nullable BitmapSerdeFactory bitmapSerdeFactory,
@JsonProperty("dimensionCompression") @Nullable CompressionStrategy
dimensionCompression,
+ @JsonProperty("stringDictionaryEncoding") @Nullable
StringEncodingStrategy stringDictionaryEncoding,
Review Comment:
>Is there a reason not to make it a configuration of the column itself? I'm
guessing this is being done out of convenience, but I'm hoping that it is
relatively easy to make it a configuration of the column too?
I am really into making this possible, I think every column should be
allowed to have an `IndexSpec` or something like it of their own basically, but
right now the dimension handler is not created directly from the dimension
schema, so there is a fair bit of plumbing to do to make this possible. As
such, I'd rather make this change as a follow-up since there are enough moving
parts here already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
