clintropolis commented on code in PR #12277:
URL: https://github.com/apache/druid/pull/12277#discussion_r980394106
##########
processing/src/main/java/org/apache/druid/segment/DictionaryEncodedColumnMerger.java:
##########
@@ -384,7 +387,10 @@ public void writeIndexes(@Nullable List<IntBuffer>
segmentRowNumConversions) thr
}
}
-
+ protected DictionaryWriter<T> getWriter(String fileName)
Review Comment:
I did a default implementation so that this change is less disruptive, i
initially had it as abstract. The issue is that the writer and other stuff are
not created/open at the time the merger is constructed, rather it happens when
the merging starts. Changing that sounds a bit disruptive and I'd rather not
make that change as part of this PR, but am happy to change this method back to
being abstract
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
