599166320 commented on code in PR #13168:
URL: https://github.com/apache/druid/pull/13168#discussion_r990634715
##########
processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java:
##########
@@ -90,13 +92,27 @@ public QueryRunner<ScanResultValue> mergeRunners(
// in single thread and in Jetty thread instead of processing thread
return (queryPlus, responseContext) -> {
ScanQuery query = (ScanQuery) queryPlus.getQuery();
- ScanQuery.verifyOrderByForNativeExecution(query);
// Note: this variable is effective only when queryContext has a timeout.
// See the comment of ResponseContext.Key.TIMEOUT_AT.
final long timeoutAt = System.currentTimeMillis() +
QueryContexts.getTimeout(queryPlus.getQuery());
responseContext.putTimeoutTime(timeoutAt);
+ if (query.scanOrderByNonTime()) {
Review Comment:
scanOrderByNonTime不仅仅是ScanQueryRunnerFactory在用，ScanQueryQueryToolChest.mergeResults
里面也需要使用到scanOrderByNonTime，目前我没有想到好的办法，暂时放在ScanQuery。如果有更合适的修改，请跟我说一下。
##########
processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java:
##########
@@ -90,13 +92,27 @@ public QueryRunner<ScanResultValue> mergeRunners(
// in single thread and in Jetty thread instead of processing thread
return (queryPlus, responseContext) -> {
ScanQuery query = (ScanQuery) queryPlus.getQuery();
- ScanQuery.verifyOrderByForNativeExecution(query);
// Note: this variable is effective only when queryContext has a timeout.
// See the comment of ResponseContext.Key.TIMEOUT_AT.
final long timeoutAt = System.currentTimeMillis() +
QueryContexts.getTimeout(queryPlus.getQuery());
responseContext.putTimeoutTime(timeoutAt);
+ if (query.scanOrderByNonTime()) {
Review Comment:
ScanOrderByNonTime is not only used by ScanQueryRunnerFactory,
ScanQueryQueryToolChest ScanOrderByNonTime also needs to be used in
mergeResults. At present, I haven't thought of a good way to do this. I put it
in ScanQuery for the time being. If there is a more appropriate modification,
please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
