paul-rogers commented on code in PR #13168:
URL: https://github.com/apache/druid/pull/13168#discussion_r990525034
##########
processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java:
##########
@@ -234,6 +234,7 @@ private Object getColumnValue(int i)
final Object value;
if (legacy &&
allColumns.get(i).equals(LEGACY_TIMESTAMP_KEY)) {
+ Preconditions.checkNotNull(selector);
Review Comment:
This is OK, and will throw an NPE if the selector is null. But, the very
next line will be pretty good at throwing an NPE anyway if the selector is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
