599166320 commented on code in PR #13168:
URL: https://github.com/apache/druid/pull/13168#discussion_r990634715
##########
processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java:
##########
@@ -90,13 +92,27 @@ public QueryRunner<ScanResultValue> mergeRunners(
// in single thread and in Jetty thread instead of processing thread
return (queryPlus, responseContext) -> {
ScanQuery query = (ScanQuery) queryPlus.getQuery();
- ScanQuery.verifyOrderByForNativeExecution(query);
// Note: this variable is effective only when queryContext has a timeout.
// See the comment of ResponseContext.Key.TIMEOUT_AT.
final long timeoutAt = System.currentTimeMillis() +
QueryContexts.getTimeout(queryPlus.getQuery());
responseContext.putTimeoutTime(timeoutAt);
+ if (query.scanOrderByNonTime()) {
Review Comment:
ScanOrderByNonTimeb is used by ScanQueryRunnerFactory and
ScanQueryQueryToolChest The mergeResults is used to. At present, I don't think
of a good solution. I put it in ScanQuery temporarily. If there is a more
appropriate modification, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
