kfaraz commented on code in PR #13197:
URL: https://github.com/apache/druid/pull/13197#discussion_r994083255
##########
server/src/main/java/org/apache/druid/server/coordinator/duty/EmitClusterStatsAndMetrics.java:
##########
@@ -43,41 +42,31 @@ public class EmitClusterStatsAndMetrics implements
CoordinatorDuty
{
private static final Logger log = new
Logger(EmitClusterStatsAndMetrics.class);
- public static final String TOTAL_CAPACITY = "totalCapacity";
public static final String TOTAL_HISTORICAL_COUNT = "totalHistoricalCount";
public static final String MAX_REPLICATION_FACTOR = "maxReplicationFactor";
private final DruidCoordinator coordinator;
private final String groupName;
private final boolean isContainCompactSegmentDuty;
+ private final ServiceEmitter emitter;
- public EmitClusterStatsAndMetrics(DruidCoordinator coordinator, String
groupName, boolean isContainCompactSegmentDuty)
+ public EmitClusterStatsAndMetrics(
+ DruidCoordinator coordinator,
+ String groupName,
+ boolean isContainCompactSegmentDuty,
+ ServiceEmitter emitter
Review Comment:
There is a single DI'd instance of `ServiceEmitter` that gets passed around.
The emitter itself and the dimension map that it carries are immutable, so we
should be good there.
Unfortunately, we didn't have any existing test that verified (all) the
dimensions that were being emitted in a metric event. Such tests passing would
have helped us validate this fully. But at least looking at the code, we
shouldn't be breaking anything.
I will be doing some further cluster testing today to further verify the
emitted metric events. We should be able to add some sim tests for this too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
