kfaraz commented on code in PR #13197: URL: https://github.com/apache/druid/pull/13197#discussion_r994743260
########## server/src/main/java/org/apache/druid/server/coordinator/TierLoadingState.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.server.coordinator; + +import org.apache.druid.timeline.SegmentId; + +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.ConcurrentHashMap; + +/** + * Contains segments being loaded or replicated in a tier. + */ +public class TierLoadingState +{ + private int lifetime; Review Comment: This is the current code: https://github.com/apache/druid/blob/45dfd679e92e668172c470c37615e7447b601af1/server/src/main/java/org/apache/druid/server/coordinator/ReplicationThrottler.java#L73-L98 Here too a tier may be busy for a period greater than the lifetime, the lifetime would keep decreasing and we would keep alerting for this tier. Saying that the load queue is stuck is probably not the correct message here and is causing the confusion. But AFAICT, the behaviour is unchanged. Or are you talking about a `TierLoadingState` that doesn't have any segments inside and is empty? That has been handled like this: ``` // Reset state for inactive tiers inactiveTiers.forEach(currentlyReplicating::remove); ``` The next time when a replica comes for this tier, a new entry would be created with a fresh lifetime value. The same handling has been done for moving segments as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
