kfaraz commented on code in PR #13197: URL: https://github.com/apache/druid/pull/13197#discussion_r993734456
########## server/src/main/java/org/apache/druid/server/coordinator/TierLoadingState.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.server.coordinator; + +import org.apache.druid.timeline.SegmentId; + +import java.util.ArrayList; +import java.util.List; +import java.util.concurrent.ConcurrentHashMap; + +/** + * Contains segments being loaded or replicated in a tier. + */ +public class TierLoadingState +{ + private int lifetime; + private final ConcurrentHashMap<SegmentId, String> processingSegments = new ConcurrentHashMap<>(); Review Comment: However, this PR does modify the definition of ~`replicationThrottleLimit` and~ `maxSegmentsInNodeLoadingQueue` slightly (docs to be updated). The limits now apply on number of assignments done during a single coordinator run rather than items in the queue at a given instant. This change was done to: - make the configs easier to use - ensure that the configs actually take effect. In some cases (where loading happens quickly enough), these limits are constantly violated.~ Edit: the only modification done to the behaviour of `replicationThrottleLimit` is that now it doesn't apply to the first replica on any tier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
