AmatyaAvadhanula commented on code in PR #13172:
URL: https://github.com/apache/druid/pull/13172#discussion_r995401178
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -108,17 +108,20 @@ public TaskLockbox(
/**
* Wipe out our current in-memory state and resync it from our bundled
{@link TaskStorage}.
+ *
+ * @return SyncResult which needs to be processed by the caller
*/
- public void syncFromStorage()
+ public SyncResult syncFromStorage()
{
giant.lock();
try {
// Load stuff from taskStorage first. If this fails, we don't want to
lose all our locks.
- final Set<String> storedActiveTasks = new HashSet<>();
Review Comment:
Thanks for pointing this out. I've reverted the change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
