AmatyaAvadhanula commented on code in PR #13172:
URL: https://github.com/apache/druid/pull/13172#discussion_r996249897
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskLockboxTest.java:
##########
@@ -1258,6 +1259,39 @@ public void testGetLockedIntervalsForRevokedLocks()
throws Exception
);
}
+ @Test
+ public void testFailedToReacquireTaskLock() throws Exception
+ {
+ final Task badTask0 = NoopTask.withGroupId("BadTask");
Review Comment:
I added a TestLockbox class which returns null for tasks whose group
contains "BadTask". I'm not sure it's the best approach to test these changes.
I'm hoping you could take a look and suggest a better approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
