kfaraz commented on code in PR #13172:
URL: https://github.com/apache/druid/pull/13172#discussion_r996439170
##########
indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskLockboxTest.java:
##########
@@ -1258,6 +1259,39 @@ public void testGetLockedIntervalsForRevokedLocks()
throws Exception
);
}
+ @Test
+ public void testFailedToReacquireTaskLock() throws Exception
+ {
+ final Task badTask0 = NoopTask.withGroupId("BadTask");
Review Comment:
The testing approach itself is fine but the names can be made a little more
self-explanatory,
like "TaskWithFailingLockAcquisition" or something. Name the Task instances
also accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
