vtlim commented on code in PR #13224:
URL: https://github.com/apache/druid/pull/13224#discussion_r996167237


##########
docs/development/extensions-contrib/prometheus.md:
##########
@@ -29,7 +29,13 @@ To use this Apache Druid extension, 
[include](../../development/extensions.md#lo
 
 This extension exposes [Druid 
metrics](https://druid.apache.org/docs/latest/operations/metrics.html) for 
collection by a Prometheus server (https://prometheus.io/).
 
-Emitter is enabled by setting `druid.emitter=prometheus` 
[configs](https://druid.apache.org/docs/latest/configuration/index.html#emitting-metrics)
 or include `prometheus` in the composing emitter list. 
+Emitter is enabled by setting `druid.emitter=prometheus` 
[configs](https://druid.apache.org/docs/latest/configuration/index.html#enabling-metrics)
 or include `prometheus` in the composing emitter list. 
+
+In certain instances, Druid processes may be colocated on the same host. For 
example, the Broker and Router may share the same server. Other colocated 
processes include the Historical and MiddleManager or the Coordinator and 
Overlord. When you have colocated processes, specify 
`druid.emitter.prometheus.port` separately for each process on each host. For 
example, even if the Broker and Router share the same host, the Broker runtime 
properties and the Router runtime properties each need to list 
`druid.emitter.prometheus.port`, and the port value for both must be different. 
While peon tasks are typically colocated with MiddleManagers and often 
Historicals, peons should use `pushgateway` for 
`druid.emitter.prometheus.strategy` and should not start an HTTP server to push 
metrics (they are short lived batch processes and multiple of these processes 
can be running at once) . 
+To configure push gateway for peons you can add somehting like this in you 
middlemanager runtime properties file:
+```
+druid.indexer.runner.javaOptsArray=["druid.emitter.prometheus.strategy=pushgateway","druid.emitter.prometheus.pushGatewayAddress=http://pushgatewayhost:pushgatewayport";]
+```

Review Comment:
   `````suggestion
   ```
   
druid.indexer.runner.javaOptsArray=["druid.emitter.prometheus.strategy=pushgateway","druid.emitter.prometheus.pushGatewayAddress=http://PUSHGATEWAYHOST:PUSHGATEWAYPORT";]
   ```
   Replace `PUSHGATEWAYHOST:PUSHGATEWAYPORT` with your Pushgateway address.
   `````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to