FrankChen021 commented on code in PR #13224:
URL: https://github.com/apache/druid/pull/13224#discussion_r997148958


##########
docs/development/extensions-contrib/prometheus.md:
##########
@@ -46,13 +47,18 @@ All the configuration parameters for the Prometheus emitter 
are under `druid.emi
 | `druid.emitter.prometheus.pushGatewayAddress` | Pushgateway address. 
Required if using `pushgateway` strategy.                                       
                                                                                
                                                  | no        | none            
                     |
 |`druid.emitter.prometheus.flushPeriod`|Emit metrics to Pushgateway every 
`flushPeriod` seconds. Required if `pushgateway` strategy is used.|no|15|
 
+### Different ports for colocated druid processes
+
+In certain instances, Druid processes may be colocated on the same host. For 
example, the Broker and Router may share the same server. Other colocated 
processes include the Historical and MiddleManager or the Coordinator and 
Overlord. When you have colocated processes, specify 
`druid.emitter.prometheus.port` separately for each process on each host. For 
example, even if the Broker and Router share the same host, the Broker runtime 
properties and the Router runtime properties each need to list 
`druid.emitter.prometheus.port`, and the port value for both must be different.
+
 ### Override properties for Peon Tasks
 
 Peon tasks are created dynamically by middle managers and have dynamic host 
and port addresses. Since the `exporter` strategy allows Prometheus to read 
only from a fixed address, it cannot be used for peon tasks.
 So, these tasks need to be configured to use `pushgateway` strategy to push 
metrics from Druid to prometheus gateway.
 
 If this emitter is configured to use `exporter` strategy globally, some of the 
above configurations need to be overridden in the middle manager so that 
spawned peon tasks can still use the `pushgateway` strategy.
 
+

Review Comment:
   ```suggestion
   
   ```
   
   Extra change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to