clintropolis commented on code in PR #13085:
URL: https://github.com/apache/druid/pull/13085#discussion_r997557552
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/PlannerContext.java:
##########
@@ -77,6 +78,7 @@
private final String sql;
private final DruidOperatorTable operatorTable;
private final ExprMacroTable macroTable;
+ private final JoinableFactoryWrapper jfw;
Review Comment:
super super nit: tiny variable name doesn't seem very consistent with other
names 😅 (in a few other places too)
##########
server/src/main/java/org/apache/druid/server/LocalQuerySegmentWalker.java:
##########
@@ -94,12 +93,13 @@ public <T> QueryRunner<T> getQueryRunnerForIntervals(final
Query<T> query, final
final AtomicLong cpuAccumulator = new AtomicLong(0L);
- final Function<SegmentReference, SegmentReference> segmentMapFn =
joinableFactoryWrapper.createSegmentMapFn(
- analysis.getJoinBaseTableFilter().map(Filters::toFilter).orElse(null),
- analysis.getPreJoinableClauses(),
- cpuAccumulator,
- analysis.getBaseQuery().orElse(query)
- );
+ Function<SegmentReference, SegmentReference> segmentMapFn = analysis
Review Comment:
super nit: `final` to match other lines 😅 (few other places too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
