somu-imply commented on code in PR #13085:
URL: https://github.com/apache/druid/pull/13085#discussion_r996171524
##########
benchmarks/src/test/java/org/apache/druid/benchmark/query/SqlBenchmark.java:
##########
@@ -88,8 +86,8 @@
*/
@State(Scope.Benchmark)
@Fork(value = 1)
-@Warmup(iterations = 5)
-@Measurement(iterations = 15)
+@Warmup(iterations = 3)
+@Measurement(iterations = 10)
Review Comment:
This was reverted. Wherever the cpuAccumulators were reused, we passed a
variable but where they were not used downstream I have used a `new
AtomicLong()`.
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/InputNumberDataSource.java:
##########
@@ -81,6 +92,29 @@ public boolean isConcrete()
return false;
}
+ @Override
+ public Function<SegmentReference, SegmentReference> createSegmentMapFunction(
+ Query query,
+ AtomicLong cpuTime
+ )
+ {
+ final DataSource dataSourceWithInlinedChannelData =
broadcastJoinHelper.inlineChannelData(query.getDataSource());
Review Comment:
I added the check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
