somu-imply commented on code in PR #13085:
URL: https://github.com/apache/druid/pull/13085#discussion_r997391822
##########
sql/src/main/java/org/apache/druid/sql/calcite/external/ExternalDataSource.java:
##########
@@ -141,7 +141,7 @@ public DataSource withUpdatedDataSource(DataSource
newSource)
@Override
public byte[] getCacheKey()
{
- return null;
+ return new byte[0];
Review Comment:
So where the `isCacheable` for the data source is false, the `getCacheKey()`
should return null for those data sources. Is my understanding correct ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
