zachjsh commented on code in PR #13165: URL: https://github.com/apache/druid/pull/13165#discussion_r1013413235
########## server/src/main/java/org/apache/druid/catalog/model/TableSpec.java: ########## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.catalog.model; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonInclude; +import com.fasterxml.jackson.annotation.JsonInclude.Include; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.google.common.base.Strings; +import org.apache.druid.java.util.common.IAE; + +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Objects; + +/** + * Definition of a table "hint" in the metastore, between client and + * Druid, and between Druid nodes. + * <p> + * This class is a simple holder of values. Semantics on top of the values + * are provided separately: by the catalog object model for writes, and + * by various Java classes for reads. + */ +public class TableSpec +{ + private final String type; + private final Map<String, Object> properties; + private final List<ColumnSpec> columns; + + @JsonCreator + public TableSpec( + @JsonProperty("type") final String type, + @JsonProperty("properties") final Map<String, Object> properties, + @JsonProperty("columns") final List<ColumnSpec> columns + ) + { + this.type = type; + this.properties = properties == null ? Collections.emptyMap() : properties; + this.columns = columns == null ? Collections.emptyList() : columns; + + // Note: no validation here. If a bad definition got into the + // DB, don't prevent deserialization. + } + + public TableSpec withProperties(final Map<String, Object> properties) + { + return new TableSpec(type, properties, columns); + } + + public TableSpec withColumns(final List<ColumnSpec> columns) + { + return new TableSpec(type, properties, columns); + } + + public TableSpec withProperty(String key, Object value) Review Comment: not used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
