gianm commented on code in PR #13365:
URL: https://github.com/apache/druid/pull/13365#discussion_r1035602360


##########
docs/operations/single-server.md:
##########
@@ -42,37 +43,43 @@ The startup scripts for these example configurations run a 
single ZK instance al
 
 The example configurations run the Druid Coordinator and Overlord together in 
a single process using the optional configuration 
`druid.coordinator.asOverlord.enabled=true`, described in the [Coordinator 
configuration documentation](../configuration/index.md#coordinator-operation).
 
+The `start-druid` is a generic launch script for starting druid services on 
single server, it accepts optional arguments like services, memory and config.
+All reference configurations can be acheived by passing appropriate arguments 
to this script.
+Existing launch scripts are deprecated and will be removed in the next 
release. 

Review Comment:
   > Existing launch scripts are deprecated and will be removed in the next 
release.
   
   I'd rather not include this line ☝️ at all, because IMO we should make the 
decision to drop the old scripts separately from adding this new feature. Also, 
never promise anything will happen in "the next release". It's almost a 
guarantee that it won't happen 🙂



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to