gianm commented on code in PR #13365:
URL: https://github.com/apache/druid/pull/13365#discussion_r1036417863
##########
examples/bin/supervise:
##########
@@ -179,13 +195,28 @@ usage() unless GetOptions(
'vardir|d=s',
'kill-timeout|t=i',
'chdir=s',
- 'svlogd:s'
+ 'svlogd:s',
+ 'array|a=s{,}'
Review Comment:
I don't think there is a need to declare a target for each argument since
`\%opt` is the first arg here. GetOptions has two modes:
1. Provide a hashref (like `\%opt`) first; all options get written as keys
to that hashref.
2. Provide a target for each option.
We're using (1) here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
