findingrish commented on code in PR #13365:
URL: https://github.com/apache/druid/pull/13365#discussion_r1035946605
##########
examples/bin/supervise:
##########
@@ -179,13 +195,28 @@ usage() unless GetOptions(
'vardir|d=s',
'kill-timeout|t=i',
'chdir=s',
- 'svlogd:s'
+ 'svlogd:s',
+ 'array|a=s{,}'
Review Comment:
I have a question regarding your suggestion. How will this line
`@config_lines = @{${'commands'}}` work given `commands` is not declared?
Did you mean something like this?
```
usage() unless GetOptions(
\%opt,
'conf|c=s',
'vardir|d=s',
'kill-timeout|t=i',
'chdir=s',
'svlogd:s',
'command=s@' => \@commands
);
usage() unless ((@commands || $opt{'conf'}) && $opt{'vardir'});
my @config_lines;
# get commands to execute either from reading the config file or command line
if (not defined $opt{'conf'}) {
@config_lines = @commands
} else {
@config_lines = read_config_file($opt{'conf'});
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
