imply-cheddar commented on PR #13501: URL: https://github.com/apache/druid/pull/13501#issuecomment-1343706487
It's complaining that parts of the if conditions that you changed when you adjusted the `isQuery()` are not covered in the tests. It needs a branch coverage of 50%, currently 11 of 24 branches are covered. So you just need one more branch covered. Just for posterity, it's probably great to try to find a way to cover at least one of those branches... It looks like there is a `ServerManagerTest` and a `ClientQuerySegmentWalkerTest`. It is probably worth it to just look and see if there's a relatively straightforward way to build tests for one/both of those classes that get the exception to be thrown. Other than that, i think this is ready for merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
