somu-imply commented on code in PR #13501:
URL: https://github.com/apache/druid/pull/13501#discussion_r1042563236


##########
processing/src/main/java/org/apache/druid/query/JoinDataSource.java:
##########
@@ -479,4 +481,47 @@ public byte[] getCacheKey()
     }
     return keyBuilder.build();
   }
+
+  @Override
+  public DataSourceAnalysis getAnalysisForDataSource()

Review Comment:
   The one in the constructor was calling this only. Made a slight change to 
have the analysis in the constructor call a private method to populate the 
analysis and this public method just to return the one in the constructor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to