somu-imply commented on code in PR #13501:
URL: https://github.com/apache/druid/pull/13501#discussion_r1041774694
##########
processing/src/main/java/org/apache/druid/query/QueryDataSource.java:
##########
@@ -112,6 +113,25 @@ public byte[] getCacheKey()
return null;
}
+ @Override
+ public DataSourceAnalysis getAnalysisForDataSource()
+ {
+ return getAnalysisForDataSource(null);
+ }
+
+ @Override
+ public DataSourceAnalysis getAnalysisForDataSource(Query<?> query)
+ {
+ final Query<?> subQuery = this.getQuery();
+ if (!(subQuery instanceof BaseQuery)) {
+ // We must verify that the subQuery is a BaseQuery, because it is
required to make "getBaseQuerySegmentSpec"
+ // work properly. All built-in query types are BaseQuery, so we only
expect this with funky extension queries.
Review Comment:
The comment has been updated to point to `DataSourceAnalysis.
getBaseQuerySegmentSpec`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
