clintropolis commented on code in PR #13561:
URL: https://github.com/apache/druid/pull/13561#discussion_r1049145239
##########
processing/src/main/java/org/apache/druid/segment/nested/NestedFieldLiteralDictionaryEncodedColumn.java:
##########
@@ -156,7 +156,11 @@ public String lookupName(int id)
@Override
public int lookupId(String name)
{
- return dictionary.indexOf(getIdFromGlobalDictionary(name));
+ final int globalId = getIdFromGlobalDictionary(name);
+ if (globalId < 0) {
+ return -1;
+ }
Review Comment:
nope, dim selector doesn't have that contract since we pushed all of that
business inside `BitmapColumnIndex`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
