clintropolis commented on code in PR #13561:
URL: https://github.com/apache/druid/pull/13561#discussion_r1049146027
##########
processing/src/test/java/org/apache/druid/query/scan/NestedDataScanQueryTest.java:
##########
@@ -463,13 +462,13 @@ public void testExpectedTypes() throws Exception
NESTED_SPARSE_MIXED_NUMERIC_FIELD
);
Assert.assertNotNull(sparseMixedNumericValueSelector);
- Assert.assertTrue(sparseMixedNumericValueSelector instanceof
DimensionDictionarySelector);
+ Assert.assertTrue(sparseMixedNumericValueSelector instanceof
ColumnValueSelector);
ColumnValueSelector sparseMixedValueSelector =
columnSelectorFactory.makeColumnValueSelector(
NESTED_SPARSE_MIXED_FIELD
);
Assert.assertNotNull(sparseMixedValueSelector);
- Assert.assertTrue(sparseMixedValueSelector instanceof
DimensionDictionarySelector);
+ Assert.assertTrue(sparseMixedValueSelector instanceof ColumnValueSelector);
Review Comment:
yeah fair, will add the negative test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
