imply-cheddar commented on code in PR #13561:
URL: https://github.com/apache/druid/pull/13561#discussion_r1049175013
##########
processing/src/main/java/org/apache/druid/segment/nested/NestedFieldLiteralDictionaryEncodedColumn.java:
##########
@@ -146,7 +146,7 @@ public String lookupName(int id)
final int globalId = dictionary.get(id);
if (globalId < globalDictionary.size()) {
return StringUtils.fromUtf8Nullable(globalDictionary.get(globalId));
- } else if (globalId < adjustLongId + globalLongDictionary.size()) {
+ } else if (globalId < globalDictionary.size() +
globalLongDictionary.size()) {
Review Comment:
Does it makes sense to unify it the other way around? Make this `globalId <
adjustDoubleId`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
