abhagraw commented on PR #13535: URL: https://github.com/apache/druid/pull/13535#issuecomment-1354263606
@paul-rogers Have updated the code as per comments. I have moved most of the s3 related code to a separate s3TestUtil which is being used by both `ITS3SQLBasedIngestionTest` and `AbstractS3InputSourceParallelIndexTest`. There will be some amount of code duplication because msq related tests need to inherit from `AbstractITSQLBasedIngestionTest` while the test being migrated from old IT framework have a hierarchical structure already in place. Also, I would recommend you to checkout `AbstractITSQLBasedIngestion ` class - which contains most of the methods we use in this test with doc strings. Not sure - if we want to have the same being mentioned in each test. (We are verifying the results after ingesting data). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
