github-code-scanning[bot] commented on code in PR #13535: URL: https://github.com/apache/druid/pull/13535#discussion_r1055370005
########## integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/indexer/AbstractITBatchIndexTest.java: ########## @@ -93,14 +99,149 @@ private static final Logger LOG = new Logger(AbstractITBatchIndexTest.class); - @Inject - protected IntegrationTestingConfig config; @Inject protected SqlTestQueryHelper sqlQueryHelper; @Inject ClientInfoResourceTestClient clientInfoResourceTestClient; + @Inject + private MsqTestQueryHelper msqHelper; + + @Inject + protected TestQueryHelper queryHelper; Review Comment: ## Field masks field in super class This field shadows another field called [queryHelper](1) in a superclass. [Show more details](https://github.com/apache/druid/security/code-scanning/3575) ########## integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/msq/ITAzureSQLBasedIngestionTest.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.testsEx.msq; + +import com.fasterxml.jackson.databind.ObjectMapper; +import com.google.inject.Inject; +import junitparams.Parameters; +import junitparams.naming.TestCaseName; +import org.apache.druid.guice.annotations.Json; +import org.apache.druid.java.util.common.Pair; +import org.apache.druid.testsEx.categories.S3DeepStorage; +import org.apache.druid.testsEx.config.DruidTestRunner; +import org.apache.druid.testsEx.indexer.AbstractAzureInputSourceParallelIndexTest; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; + +import java.util.List; + +/** + * IMPORTANT: + * To run this test, you must set the following env variables in the build environment - + * <p> + * The AZURE account, key and container should be set in AZURE_ACCOUNT, AZURE_KEY and AZURE_CONTAINER respectively. + * <p> + * <a href="https://druid.apache.org/docs/latest/development/extensions-core/azure.html";>Azure Deep Storage setup in druid</a> + */ + +@RunWith(DruidTestRunner.class) +@Category(S3DeepStorage.class) +public class ITAzureSQLBasedIngestionTest extends AbstractAzureInputSourceParallelIndexTest +{ + private static final String CLOUD_INGEST_SQL = "/multi-stage-query/wikipedia_cloud_index_msq.sql"; + private static final String INDEX_QUERIES_FILE = "/multi-stage-query/wikipedia_index_queries.json"; + + @Inject + @Json + protected ObjectMapper jsonMapper; Review Comment: ## Field masks field in super class This field shadows another field called [jsonMapper](1) in a superclass. [Show more details](https://github.com/apache/druid/security/code-scanning/3577) ########## integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/msq/ITGcsSQLBasedIngestionTest.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.testsEx.msq; + +import com.fasterxml.jackson.databind.ObjectMapper; +import com.google.inject.Inject; +import junitparams.Parameters; +import junitparams.naming.TestCaseName; +import org.apache.druid.guice.annotations.Json; +import org.apache.druid.java.util.common.Pair; +import org.apache.druid.testsEx.categories.GcsDeepStorage; +import org.apache.druid.testsEx.config.DruidTestRunner; +import org.apache.druid.testsEx.indexer.AbstractGcsInputSourceParallelIndexTest; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; + +import java.util.List; + +@RunWith(DruidTestRunner.class) +@Category(GcsDeepStorage.class) +public class ITGcsSQLBasedIngestionTest extends AbstractGcsInputSourceParallelIndexTest +{ + private static final String CLOUD_INGEST_SQL = "/multi-stage-query/wikipedia_cloud_index_msq.sql"; + private static final String INDEX_QUERIES_FILE = "/multi-stage-query/wikipedia_index_queries.json"; + + @Inject + @Json + protected ObjectMapper jsonMapper; Review Comment: ## Field masks field in super class This field shadows another field called [jsonMapper](1) in a superclass. [Show more details](https://github.com/apache/druid/security/code-scanning/3576) ########## integration-tests-ex/cases/src/test/java/org/apache/druid/testsEx/msq/ITS3SQLBasedIngestionTest.java: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.testsEx.msq; + +import com.fasterxml.jackson.databind.ObjectMapper; +import com.google.inject.Inject; +import junitparams.Parameters; +import junitparams.naming.TestCaseName; +import org.apache.druid.guice.annotations.Json; +import org.apache.druid.java.util.common.Pair; +import org.apache.druid.testsEx.categories.S3DeepStorage; +import org.apache.druid.testsEx.config.DruidTestRunner; +import org.apache.druid.testsEx.indexer.AbstractS3InputSourceParallelIndexTest; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.junit.runner.RunWith; + +import java.util.List; + +/** + * IMPORTANT: + * To run this test, you must set the following env variables in the build environment + * DRUID_CLOUD_BUCKET - s3 Bucket to store in (value to be set in druid.storage.bucket) + * DRUID_CLOUD_PATH - path inside the bucket where the test data files will be uploaded + * (this will also be used as druid.storage.baseKey for s3 deep storage setup) + * <p> + * The AWS key, secret and region should be set in + * AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY and AWS_REGION respectively. + * <p> + * <a href="https://druid.apache.org/docs/latest/development/extensions-core/s3.html";>S3 Deep Storage setup in druid</a> + */ + +@RunWith(DruidTestRunner.class) +@Category(S3DeepStorage.class) +public class ITS3SQLBasedIngestionTest extends AbstractS3InputSourceParallelIndexTest +{ + private static final String CLOUD_INGEST_SQL = "/multi-stage-query/wikipedia_cloud_index_msq.sql"; + private static final String INDEX_QUERIES_FILE = "/multi-stage-query/wikipedia_index_queries.json"; + + @Inject + @Json + protected ObjectMapper jsonMapper; Review Comment: ## Field masks field in super class This field shadows another field called [jsonMapper](1) in a superclass. [Show more details](https://github.com/apache/druid/security/code-scanning/3578) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
