LakshSingla opened a new pull request, #13625:
URL: https://github.com/apache/druid/pull/13625
### Description
Calcite's test framework has been revamped recently to reduce the dependence
on statically created objects and inject the dependency via Guice. This unlocks
the ability to inject MSQ-specific dependencies and test out the existing
Calcite's tests using the MSQ engine.
Changes accomplished in the PR:
1. Inject MSQ's specific objects using Guice so that the code path to run
the tests via Guice exists.
2. Refactor the existing test runner
a. Run steps are now chained together so that one run step can use the
results obtained from the previous run step and the final run step's results
are used in the verification
b. The query context is now not taken into account while verifying the
queries
c. Add the support to add custom verifications
3. The MSQ has an extract step that allows the query results to be extracted
from the reports before they are verified.
<hr>
##### Key changed/added classes in this PR
* `MSQTestBase`
* `CalciteSelectQueryTestMSQ`
* `QueryTestRunner`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
