LakshSingla commented on code in PR #13625:
URL: https://github.com/apache/druid/pull/13625#discussion_r1065737984
##########
processing/src/main/java/org/apache/druid/query/QueryContext.java:
##########
@@ -54,7 +54,7 @@
{
private static final QueryContext EMPTY = new QueryContext(null);
- private final Map<String, Object> context;
+ private Map<String, Object> context;
Review Comment:
This instance replace is not easily possible as the current `Query`
interface does not support replace, only override (where the keys are
preserved).
To solve this currently, I am using the ObjectMapper to create an ObjectNode
from the query object and manually clear the "context" key, which is working
fine. I also tried creating a Mockito's spy object and overriding the context
methods, however, that was failing the equals and the serde tests (presumably
because the child classes won't be the same)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
