LakshSingla commented on PR #13625: URL: https://github.com/apache/druid/pull/13625#issuecomment-1376737201
One issue with the tests being written in `sql` module and the MSQ-related stuff being in the `druid-multi-stage-query` module has been that we are not able to setup the MSQ-related stuff in the `sql` module as `sql` does not contain MSQ as a dependency. After an offline discussion with @paul-rogers and @cryptoe, documented below are the few approaches that we can take up. 1. Remove the dependency of `sql` on `druid-multi-stage-query` by breaking the coupling, add `druid-multi-stage-query` as a dependency of `sql` and proceed as mentioned above. However since currently MSQ is present as an extension, this dependency of MSQ on `sql` seems slightly weird. This approach however would be pretty clean. 2. Use one of the test case definitions like the one proposed in https://github.com/apache/druid/pull/13106 to make the test cases independent from the execution which would also help the PR. This would also help prevent the duplication of tests in the Druid Catalog. 3. Add the `druid-multi-stage-query` as a runtime dependency to `sql` (not sure how this would have worked out, just an idea at this point). 4. Inherit the tests from the sql in the `druid-multi-stage-query`, override the methods that will help add the msq tests and add the plumbing. The only drawback of this approach is that debugging the individual test cases would be difficult since there won't be a run configuration corresponding to them. However that's a minor dev discomfort. Therefore going down with this approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
